Fixed potential file system corruption when truncating or overwriting file data with fault tolerant mode enabled (#78)

* _fx_fault_tolerant_cleanup_FAT_chain(): Add checks to prevent starting a new cluster deletion session in some corner cases where the end of the chain is reached.

* Fixed formatting of previous commit.

common/src/fx_fault_tolerant_cleanup_FAT_chain.c

@@ -207,7 +207,7 @@ ULONG                        last_FAT_sector;
 
     /* At this point, the head_cluster points to the cluster chain that is to be removed. */
 
-    /* Tail cluster points to the back of the origianal FAT chain where the new chain is attached to.
+    /* Tail cluster points to the back of the original FAT chain where the new chain is attached to.
        The remove process terminates once this cluster is encountered. */
     tail_cluster = _fx_utility_32_unsigned_read((UCHAR *)&FAT_chain -> fx_fault_tolerant_FAT_chain_insertion_back);
 
@@ -262,7 +262,11 @@ ULONG                        last_FAT_sector;
             {
                 if (head_cluster == next_session || next_session == FX_FREE_CLUSTER)
                 {
-                    next_session = next_cluster;
+                    /* Do not start another session if this is the end of the chain.  */
+                    if (next_cluster != tail_cluster)
+                    {
+                        next_session = next_cluster;
+                    }
                 }
                 break;
             }
@@ -277,7 +281,11 @@ ULONG                        last_FAT_sector;
         /* Get next session. */
         if (cache_count == cache_max)
         {
-            next_session = next_cluster;
+            /* Do not start another session if this is the end of the chain.  */
+            if (next_cluster != tail_cluster)
+            {
+                next_session = next_cluster;
+            }
         }
 
         /* Update head cluster and next session into log file. */

ports/rxv1/gnu/CMakeLists.txt

@@ -0,0 +1,9 @@
+target_sources(${PROJECT_NAME} PRIVATE
+    # {{BEGIN_TARGET_SOURCES}}
+
+    # {{END_TARGET_SOURCES}}
+)
+
+target_include_directories(${PROJECT_NAME} PUBLIC
+    ${CMAKE_CURRENT_LIST_DIR}/inc
+)

ports/rxv1/gnu/inc/fx_port.h

@@ -0,0 +1,24 @@
+/***************************************************************************
+ * Copyright (c) 2024 Microsoft Corporation 
+ * 
+ * This program and the accompanying materials are made available under the
+ * terms of the MIT License which is available at
+ * https://opensource.org/licenses/MIT.
+ * 
+ * SPDX-License-Identifier: MIT
+ **************************************************************************/
+
+
+/**************************************************************************/
+/**************************************************************************/
+/**                                                                       */ 
+/** FileX Component                                                       */
+/**                                                                       */
+/**   Port Specific                                                       */
+/**                                                                       */
+/**************************************************************************/
+/**************************************************************************/
+
+/* Include the generic version of fx_port.h. */
+#include "../../../generic/inc/fx_port.h"
+

ports/rxv2/gnu/CMakeLists.txt

@@ -0,0 +1,9 @@
+target_sources(${PROJECT_NAME} PRIVATE
+    # {{BEGIN_TARGET_SOURCES}}
+
+    # {{END_TARGET_SOURCES}}
+)
+
+target_include_directories(${PROJECT_NAME} PUBLIC
+    ${CMAKE_CURRENT_LIST_DIR}/inc
+)

ports/rxv2/gnu/inc/fx_port.h

@@ -0,0 +1,24 @@
+/***************************************************************************
+ * Copyright (c) 2024 Microsoft Corporation 
+ * 
+ * This program and the accompanying materials are made available under the
+ * terms of the MIT License which is available at
+ * https://opensource.org/licenses/MIT.
+ * 
+ * SPDX-License-Identifier: MIT
+ **************************************************************************/
+
+
+/**************************************************************************/
+/**************************************************************************/
+/**                                                                       */ 
+/** FileX Component                                                       */
+/**                                                                       */
+/**   Port Specific                                                       */
+/**                                                                       */
+/**************************************************************************/
+/**************************************************************************/
+
+/* Include the generic version of fx_port.h. */
+#include "../../../generic/inc/fx_port.h"
+

ports/rxv3/gnu/CMakeLists.txt

@@ -0,0 +1,9 @@
+target_sources(${PROJECT_NAME} PRIVATE
+    # {{BEGIN_TARGET_SOURCES}}
+
+    # {{END_TARGET_SOURCES}}
+)
+
+target_include_directories(${PROJECT_NAME} PUBLIC
+    ${CMAKE_CURRENT_LIST_DIR}/inc
+)

ports/rxv3/gnu/inc/fx_port.h

@@ -0,0 +1,24 @@
+/***************************************************************************
+ * Copyright (c) 2024 Microsoft Corporation 
+ * 
+ * This program and the accompanying materials are made available under the
+ * terms of the MIT License which is available at
+ * https://opensource.org/licenses/MIT.
+ * 
+ * SPDX-License-Identifier: MIT
+ **************************************************************************/
+
+
+/**************************************************************************/
+/**************************************************************************/
+/**                                                                       */ 
+/** FileX Component                                                       */
+/**                                                                       */
+/**   Port Specific                                                       */
+/**                                                                       */
+/**************************************************************************/
+/**************************************************************************/
+
+/* Include the generic version of fx_port.h. */
+#include "../../../generic/inc/fx_port.h"
+